-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also escape % #184
Also escape % #184
Conversation
Hi @Zinggi iex> YamlElixir.read_from_string!("default: %d.%m.%Y")
%{"default" => "%d.%m.%Y"} Anyway, please fix the test, too. I don't see why we couldn't merge this. WDYT @jlgeering ? |
Pull Request Test Coverage Report for Build d5d4f5ef770f205dc6ce138d1efc6df6d19499ee-PR-184
💛 - Coveralls |
Oh, Simplificator is doing Elixir?! Nice! |
Great, I'll also fix the tests then. Here is the ruby version to compare with YamlElixir and ymlr. It uses libyaml for it's parser:
Yes, for around 5 years now! |
The test almost looks like a copy paste error, it was the only one there without the |
LGTM => I tried to not quote too much "for readability", i.e. there is absolutely no problem in using more quotes when it helps |
Thanks a lot! |
@Zinggi we published v5.1.2 with your changes! ❤️ Thank you |
Not sure if rails uses a different yml standard, but I tried writing i18n locale files for a rails application and got this error:
For this line:
When it's quoted it works.
Not sure if it makes sense to include here and if it's actually correct. I tried scanning the standard but not really sure where to look. I found
%
under directives, but I don't know if it actually has a special meaning for values as well.Requirements